-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(opentrons-ai-client): add conditional for user prompt #15308
Conversation
add conditinal for user prompt close AUTH-433
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i get this error from react markdown when using one of the example buttons:
Warning: React.jsx: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.
i don't think react markdown likes |
change |
does it behave differently for |
yes because of conditional rendering. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it is not behaving correctly. See the image below, when user sends info with backtick, it renders as a block.
Write a protocol using the Opentrons Python Protocol API v2 for OT-2 robot according to the following description:
Labware:
- Source Labware: `Thermo Scientific Nunc 96 Well Plate 1300 uL` in slot 9
- Destination Labware: `Opentrons 96 Flat Bottom Adapter with NEST 96 Well Plate 200 uL Flat` in slot 10
- `Opentrons 96 Filter Tip Rack 1000 uL` in slot 8
- `Opentrons 96 Tip Rack 1000 uL` in slot 3
Pipette mount:
- P1000 Single-Channel GEN2 is mounted on the left
- P1000 Single-Channel GEN2 is mounted on the right
Commands:
1. Use the left-mounted P1000 Single-Channel GEN2 pipette to transfer 196 uL of reagent from wells A7, A6, A5, A2, A3
of the source labware to the corresponding wells A5, A9, A1, A10, A2 of the destination labware. Use a new tip for each transfer.
2. Use the right-mounted P1000 Single-Channel GEN2 pipette to transfer 8 uL of liquid from wells A9, A12, A6, A10, A3
of the source labware to the corresponding wells A7, A11, A6, A3, A9 of the destination labware. Use the same tip for all transfers.
not completely align with that since we use react-mark down and it take some time. https://opentrons.slack.com/archives/C074KKV6SRK/p1717189125167839 |
black background is coming from rendering of backtick. Although it is not black anymore, the backtick is still considered as a block rather than inline. Maybe we need to change this PR to account for only fixing margin. |
because the response from backend includes pre tag(backtick) What this pr does
response.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I created another ticket to solve backtick
rendering https://opentrons.atlassian.net/browse/AUTH-465
Overview
add conditional for user prompt
before
after
close AUTH-433
Test Plan
Changelog
Review requests
Risk assessment